feat(typescript): add optional builderCode to x402 client and server - #768
Open
ethanoroshiba wants to merge 6 commits into
Open
feat(typescript): add optional builderCode to x402 client and server#768ethanoroshiba wants to merge 6 commits into
ethanoroshiba wants to merge 6 commits into
Conversation
🟡 Heimdall Review Status
|
Contributor
Author
|
Note on facilitator support: the CDP-hosted facilitator supports the |
ethanoroshiba
marked this pull request as ready for review
July 29, 2026 21:37
phdargen
reviewed
Jul 30, 2026
| const client = new CdpX402Client({ builderCode: "my_client" }); | ||
| ``` | ||
|
|
||
| Service codes are only attached when the resource server advertises the `builder-code` extension in its `PaymentRequired` response — against servers that do not, the codes are dropped and the payment proceeds unattributed. |
Contributor
There was a problem hiding this comment.
Think we should change this and always attribute the client regardless of the server, dont see a good reason to drop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builderCodeonCdpX402ClientandcreateX402Serverto attach the x402builder-codeextension (clients, servera)CdpX402Clientand every EVM route oncreateX402Servernow always attaches the SDK's own service code (cdp_sdk_client/cdp_sdk_server) tos, so on-chain activity from the CDP SDK is attributed regardless of whether a caller setsbuilderCode@x402/core's extension merge treats server-declaredbuilder-codefields as authoritative, a server that declaresswould otherwise silently drop whatever the client's own extension(s) contributed for that field;CdpX402Clientnow reconciles the two after payload creation so both sides' codes survivebuilderCode→ extension still carries the SDK's own code; invalid codes rejected at init/createTest plan
builderCode); server always advertisesbuilder-codewith the SDK's own code on EVM routes (with/without a configured app code); reconciliation correctly unions the client's and server's service codes when the server's declaration would otherwise clobber the client's; manualregisterExtension/routeextensionsoverrides still take precedence